[PATCH] parsers: clarify documentation of test-parseindex2.py
Chris Jerdonek
chris.jerdonek at gmail.com
Mon Dec 2 21:43:00 UTC 2013
On Mon, Dec 2, 2013 at 11:52 AM, Sean Farley
<sean.michael.farley at gmail.com> wrote:
>
> bos at serpentine.com writes:
>
>> On Mon, Dec 2, 2013 at 8:12 AM, Chris Jerdonek <chris.jerdonek at gmail.com>wrote:
>>
>>> parsers: clarify documentation of test-parseindex2.py
>>>
>>
>> Applied, thanks.
>
> Just a heads up that Matt backed out your previous parsers patch in 96b2dd77c85d.
Thanks, Bryan. And thanks, Sean. Yeah, I saw that. This change was
partly in response to that. The previous language read like the test
module only applies to the C version, while in fact the pure Python
version is also under test, which I didn't think to check. (The new
test breaking in "pure" mode is I believe the reason he backed out the
change.) I can fix that no problem.
By the way, for patches changing C extensions, running the tests in
"pure" mode would I think be a good addition to various parts of the
wiki (e.g. the submission checklist [1]). I can go ahead and add
that.
--Chris
[1] http://mercurial.selenic.com/wiki/ContributingChanges#Submission_checklist
More information about the Mercurial-devel
mailing list