[patch bugfix] phases.py analyzeremotephases() Ignore data related to default bookmark
Roland Eggner
edvx1 at systemanalysen.net
Mon Dec 30 19:06:28 UTC 2013
# HG changeset patch
# Parent ea8cd883bfae16b4e84cc265836a4650832502bc
# User Roland Eggner < odv at systomanalyson.not s/o/e/g >
# Date 1388261728 -3600
[bugfix] phases.py analyzeremotephases() Ignore data related to default bookmark.
Appears to fix
[bugreport mercurial-2.6.2] "hg pull --debug" aborted: "... /mercurial/phases.py", line 363, in analyzeremotephases node = bin(nhex) TypeError: Odd-length string
reported at
http://thread.gmane.org/gmane.comp.version-control.mercurial.devel/62060
Bugfix does not cause any mercurial-2.8.1 “make test” errors for me.
Users hit by this bug can not simply “hg pull” from a repository providing this bugfix, probably they need either a trick (perhaps somehow switch off bookmarks support) or another way of bugfix deployment.
Probably an entry in
http://mercurial.selenic.com/wiki/UpgradeNotes
providing a convenient upgrade path would be useful for this users.
diff --git a/mercurial/phases.py b/mercurial/phases.py
--- a/mercurial/phases.py
+++ b/mercurial/phases.py
@@ -362,6 +362,8 @@ def analyzeremotephases(repo, subset, ro
for nhex, phase in roots.iteritems():
if nhex == 'publishing': # ignore data related to publish option
continue
+ if nhex == '@': # ignore data related to bookmark '@'
+ continue
node = bin(nhex)
phase = int(phase)
if phase == 0:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20131230/9ffee02f/attachment.asc>
More information about the Mercurial-devel
mailing list