[PATCH 1 of 3 RFC V4] hgweb: code selection without line numbers in file source view

[Martin Geisler]

Alexander Plavin <me at aplavin.ru> writes:

> # HG changeset patch
> # User Alexander Plavin <me at aplavin.ru>
> # Date 1372933124 -14400
> #      Thu Jul 04 14:18:44 2013 +0400
> # Node ID a1de30293d0e140b14e9d8ed5f2e7540907a81b1
> # Parent  d7b4aa1049d3fbbc2b8d24114afad82586c49db3
> hgweb: code selection without line numbers in file source view

Thanks for turning my demo into a full patch!

I would use the commit message to explain a few things:

- The requirements you have evaluated the code against:leading,
  embedded, and trailing whitespace/tabs in both the first and other
  lines; the ability to select part of lines (that ruled out using a
  elements around the entire line).

- which browsers you have tested with and their versions.

- How the new code degrades if browsers don't support this or that
  feature. How many users will this affect?

- Performance of the new solution. Does it work with a 10,000 line file?

- A note saying that the patch is based on my work :)

Basically a summary of the discussion we've had on the list so that
people can see why you picked this solution over the others.

Finally: does this not affect any tests? If the tests need updating,
then you should put that into this commit. Otherwise the commit
introduces test failures.

-- 
Martin Geisler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20130705/59561fb4/attachment.asc>