[PATCH V2 1/2] diff: add the --output option

[Ahmed S. Darwish]

On Tue, Jul 09, 2013 at 05:52:23PM -0400, Augie Fackler wrote:
> 
> On Jul 1, 2013, at 12:25 PM, Ahmed S. Darwish <darwish.07 at gmail.com> wrote:
> ...
> > 
> > diff -r 648d1974b3f3 -r c1aa2fdfc7b7 mercurial/cmdutil.py
> > --- a/mercurial/cmdutil.py	Sun Jun 30 15:19:39 2013 -0500
> > +++ b/mercurial/cmdutil.py	Mon Jul 01 18:13:30 2013 +0200
> > @@ -7,6 +7,7 @@
> > 
> > from node import hex, nullid, nullrev, short
> > from i18n import _
> > +from datetime import datetime
> > import os, sys, errno, re, tempfile
> > import util, scmutil, templater, patch, error, templatekw, revlog, copies
> > import match as matchmod
> > @@ -123,6 +124,16 @@
> >         limit = None
> >     return limit
> > 
> > +def fsfriendly(user):
> > +    """return committer's username in a short and filesystem-friendly
> > +    manner.  This basically implies removing email info, white spaces,
> > +    and other problematic characters for common filesystems.
> > +    reference: MSDN - Naming Files, Paths, and Namespaces.
> > +    """
> > +    user = re.sub('\<[^<]*@[^>]*\>', '', user)
> > +    user = re.sub("[\W]", '', user)
> > +    return user.lower()
> > +
> 
> This function could really stand to be its own patch.
> 

So should I now send a V3 version for this patch series?

Thanks,

--
Darwish
http://darwish.chasingpointers.com