[PATCH 1 of 2] hgweb: change highlighted line color to be different from 'inserted' color
Alexander Plavin
me at aplavin.ru
Mon Jul 15 13:58:19 UTC 2013
2013/7/15 Martin Geisler <martin at geisler.net>:
> Alexander Plavin <me at aplavin.ru> writes:
>
>> # HG changeset patch
>> # User Alexander Plavin <me at aplavin.ru>
>> # Date 1373722313 -14400
>> # Sat Jul 13 17:31:53 2013 +0400
>> # Node ID c4f25e9184601161b1f24aa41e2c9d6957b95654
>> # Parent 3f19e6106f17298dca51f3d3f3234590af518f4b
>> hgweb: change highlighted line color to be different from 'inserted' color
>
>> diff -r 3f19e6106f17 -r c4f25e918460 mercurial/templates/static/style-paper.css
>> --- a/mercurial/templates/static/style-paper.css Sat Jul 13 00:57:56 2013 +0400
>> +++ b/mercurial/templates/static/style-paper.css Sat Jul 13 17:31:53 2013 +0400
>> @@ -253,7 +253,7 @@
>> }
>>
>> .sourcelines > span:target {
>> - background-color: #ffff99;
>> + background-color: #bfdfff;
>> }
>
> Sounds good, but I would:
>
> 1. explain in human terms that you're changing a faint yellow (#ffff99)
> to a faint blue (#bfdfff)
Sure, will add to commit message.
>
> 2. argume somehow that the new color is okay for color blind people
> (there were a big discussion earlier that resulted in the yellow-ish
> color being selected over the usual green for inserted lines).
How can I argume this? I've tried with a simulator of different color
blindness types now, and this light blue background looks a) different
enough from other backgrounds, and b) text doesn't lose distinction on
it.
>
> --
> Martin Geisler
More information about the Mercurial-devel
mailing list