[PATCH 05 of 15 V5] bookmarks: rewrite comparing bookmarks in "commands.summary()" by "compare()"

Siddharth Agarwal sid0 at fb.com
Tue Nov 19 21:18:34 UTC 2013


On 11/07/2013 07:54 PM, FUJIWARA Katsunori wrote:
> +def summary(repo, other):
> +    (addsrc, adddst, advsrc, advdst, diverge, differ, invalid
> +     ) = compare(repo, other.listkeys('bookmarks'), repo._bookmarks,
> +                 dsthex=hex)

I think I'd prefer this written as

    r = compare(repo, other.listkeys('bookmarks'), repo._bookmarks,
dsthex=hex)
    addsrc, adddst, advsrc, advdst, diverge, differ, invalid = r

and the same goes for the other patches that use that pattern.



More information about the Mercurial-devel mailing list