[PATCH] socks proxy: socks5 proxy support for http(s) protocol
heisenbug
heisenbug at zoho.com
Tue Apr 8 15:51:13 UTC 2014
Hi Mads,
> Hi
>
> My personal opinion: This looks like a fine feature. I have no doubt
> that it solves a real problem.
>
> I also think socks proxies are used less these days than they used
> to. I think most setups with socks proxies also have http proxies ...
> and http proxies might be a better option for proxying http.
>
> I think this functionality would be valuable as a separate extension
> but do not think it is relevant to include it in core mercurial.
>
> There is also some minor coding style issues and lack of tests ...
> but that is less relevant in this context.
>
> /Mads
>
Thank you for your feedback. I have tried to convert this patch into an
extension which I've made available here:
https://bitbucket.org/bugheisen/socks_proxy/
Since I have no idea if this is the correct way to handle this, feedback
is more than welcome.
Cheers,
bug
More information about the Mercurial-devel
mailing list