[PATCH 085 of 179 tests-refactor] run-tests: move SKIPPED_STATUS into Test class
Gregory Szorc
gregory.szorc at gmail.com
Tue May 13 01:24:17 UTC 2014
On 5/10/2014 12:40 PM, Pierre-Yves David wrote:
> Greg and I meet in real live and we discussed its patches series.
>
> The general direction seems good.
>
> I've been through the first 90 patches that are code movement only. I
> check that they were d code movement as they claimed and that there was
> no unrelated changes (at least no changes unrelated to code movement).
>
> This was not a deep review of each patch seen I would like this series
> to get in before chrismass but the overall goal of the series looks
> good, the end result look not worse than the initial state. And this was
> just half of the series. The other half make run-tests use the python
> unittest machinery. This will help use integrating the test suite with
> other tools.
>
> So, the series look overall good and test pass on all patches[1].
>
> However, some of this series relies on __del__ + "del t" for clean up.
> This is very 3v1l and fragile and note something I'm willing to queue.
> I'll be happy to queue this series as soon as the involved changeset
> have been cleansed.
>
> 473d97194610 run-tests: move createenv() into Test
> c02389c8e34f run-tests: remove threadtmp as part of Test.__del__
> ac3a389bcb5c run-tests: kill daemons during Test.__del__
> b02c1068f9e1 run-tests: move success() into Test
> 9290fd204a07 run-tests: refactor runone() into gettest() and
> scheduletests()
> 641cb3d9f1cf run-tests: move scheduletests() into TestRunner
>
I've renamed __del__ to cleanup() and pushed the latest patches to
http://hg.stage.mozaws.net/hg/. run-tests-refactor-sane bookmark is what
you want.
More information about the Mercurial-devel
mailing list