[PATCH] docker: add Docker files for running an Apache mod_wsgi server

[Antoine Pitrou]

On Thu, 13 Nov 2014 17:45:33 +0100
Mads Kiilerich <mads at kiilerich.com> wrote:
> On 11/13/2014 04:36 PM, Antoine Pitrou wrote:
> > On Tue, 11 Nov 2014 20:37:44 -0800
> > Gregory Szorc <gregory.szorc at gmail.com> wrote:
> >> +
> >> +  WSGIDaemonProcess hg processes=${WSGI_PROCESSES} threads=${WSGI_THREADS} maximum-requests=${WSGI_MAX_REQUESTS} user=www-data group=www-data display-name=hg-wsgi
> > *Don't* use maximum-requests! It will corrupt some clones.
> > See http://bz.selenic.com/show_bug.cgi?id=2595#c30
> 
> I do not think that bz comment is correct / relevant in this (or that) 
> context.
> 
> This issue was about incomplete responses and handling of it. 
> maximum-requests will shut the application down _between_ requests. I 
> see no indication that it should be so stupid that it killed a process 
> that still is delivering a response.

Then you should read again.  This problem was witnessed first hand by
several people, and it could be reproduced deterministically as stated
in the issue comments.  hg.python.org has had failed clone issues until
I removed the maximum-requests setting, and the issues haven't
resurfaced after.

Unless mod_wsgi changed its implementations of maximum-requests, that
parameter should definitely not be enabled for hgweb.

Regards

Antoine.