[PATCH 1 of 3] hgweb: split some long lines in paper, gitweb and monoblue styles
Pierre-Yves David
pierre-yves.david at ens-lyon.org
Fri May 15 21:49:23 UTC 2015
On 05/15/2015 01:58 PM, Augie Fackler wrote:
> On Fri, May 15, 2015 at 12:55:19PM -0700, Pierre-Yves David wrote:
>>
>>
>> On 05/15/2015 08:25 AM, Anton Shestakov wrote:
>>> # HG changeset patch
>>> # User Anton Shestakov <engored at ya.ru>
>>> # Date 1431626863 -28800
>>> # Fri May 15 02:07:43 2015 +0800
>>> # Node ID 4830c872477ffb59e2da36ef950bba5a201659fa
>>> # Parent d1bd0fd07ee6adf4ab3be2b0a0a7c0df54d55abf
>>> hgweb: split some long lines in paper, gitweb and monoblue styles
>>>
>>> This will ease future patches for the templates.
>>>
>>> As a result of this patch, paper style has one visual change in
>>> log/shortlog/file log view: the spacing between commit message and the first
>>> tag (or branch name, or bookmark) is now roughly who spaces wide instead of one
>>> space wide. This spacing is consistent with the one between branch
>>> names/tags/bookmarks themselves, so it looks better.
>>>
>>> In gitweb style, the change from non-breakable space to regular space is
>>> consistent with other elements.
>>>
>>> In monoblue the change is not noticeable.
>>
>> This series looks fine to me, but I'm not sure how people will feel about
>> the changes.
>>
>> I feel like some change are more "consistency fixes" than others. I would
>> have helped to have each template changed in its own patch.
>>
>> I'll let people some time to react to this.
>
> I'm fine with this series as-is, if you want to take it feel
> encouraged to do so.
Pushed to the clowncopter. Thanks
--
Pierre-Yves David
More information about the Mercurial-devel
mailing list