[Bug 4818] New: test-extdiff.t fails on OS X tempfile.mkdtemp yields directories with + which fails posix _needsshellquote

[mercurial-bugs at selenic.com]

http://bz.selenic.com/show_bug.cgi?id=4818

          Priority: normal
            Bug ID: 4818
                CC: mercurial-devel at selenic.com
          Assignee: bugzilla at selenic.com
           Summary: test-extdiff.t fails on OS X tempfile.mkdtemp yields
                    directories with + which fails posix _needsshellquote
          Severity: bug
    Classification: Unclassified
                OS: Mac OS
          Reporter: timeless at gmail.com
          Hardware: PC
            Status: UNCONFIRMED
           Version: unspecified
         Component: Mercurial
           Product: Mercurial

Created attachment 1860
  --> http://bz.selenic.com/attachment.cgi?id=1860&action=edit
test-extdiff.t.err.diff

OS X's mktemp function includes '+' characters in it, and mercurial's
posix.shellquote's _needsshellquote test currently thinks '+' needs to be
quoted.

extdiff's test assumes that the mktemp function output doesn't need to be
quoted.

There are two possible fixes:
1. change posix.shellquote's _needsshellquote to allow '+' unquoted
2. write some magic for the test to handle this case.

#1 is easy (I have a patch for it)
#2 requires at least a bit of thought...

-- 
You are receiving this mail because:
You are on the CC list for the bug.