[PATCH 8 of 8] perf: replace ui.configint() by getint() for Mercurial earlier than 1.9

FUJIWARA Katsunori foozy at lares.dti.ne.jp
Fri Aug 12 00:50:24 UTC 2016


At Thu, 11 Aug 2016 02:43:33 -0400,
timeless wrote:
> 
> FUJIWARA Katsunori wrote:
> > +    v  = ui.config(section, name, None)
> 
> fwiw, you have two spaces before `=`
> 

Thank you for pointing out!

I expect check-code.py to detect this kind of problem, but now I
notice that it checks only gratuitous whitespace "after" =. Maybe, for
some column positioning like as below ?

    https://selenic.com/repo/hg/file/3.9/hgext/convert/monotone.py#l47
    https://selenic.com/repo/hg/file/3.9/mercurial/cmdutil.py#l3031

I'll fix that line in V2.

----------------------------------------------------------------------
[FUJIWARA Katsunori]                             foozy at lares.dti.ne.jp



More information about the Mercurial-devel mailing list