[PATCH 3 of 3 V2] getbundle: add `bookmarkpatterns` parameter
Pierre-Yves David
pierre-yves.david at ens-lyon.org
Wed Aug 24 22:41:36 UTC 2016
On 08/23/2016 12:22 PM, Stanislau Hlebik wrote:
> # HG changeset patch
> # User Stanislau Hlebik <stash at fb.com>
> # Date 1471947390 25200
> # Tue Aug 23 03:16:30 2016 -0700
> # Node ID d797649380c3e9dbf18d056ac52345a0fc31ddc1
> # Parent 6cad044c2ea002d3a4c1e45666e89c99b7fbdd0f
> getbundle: add `bookmarkpatterns` parameter
The next step here should be to actually use the new code instead of
making it more complex.
There is code dedicated to requesting and processing bookmark in
exchange.py. This code needs to be updated to (when possible) use the
new 'bookmarks' argument and part instead of the listkey one. This would
also get the new code run through the tests without having to build
specialized command.
In addition, I don't think the 'bookmarkspattern' belong to core yet.
(yes it contradict some of my previous messages, but things are getting
clearer now that we have piece of implementation visible).
The only user for it lives in an external extension, so the extra
argument should live there. Just make sure the part generation is
flexible enough to be wrapped by the extensions (this will be something
around the listing of bookmarks).
I know the bundle2/exchange code is flexible enough for this kind of
things as I'm doing so in a couple of extensions already.
To summaries I would like to see a V3 with.
- a new 'bookmark' part an appropriate minimal encoding (maybe reuse the
on disk format?),
- a 'bookmarks' argument to get bundle to request it,
- a capability advertising it,
- the exchange code updated to use it when available,
- no change to the listkey protocol,
- no introduction of bookmarkpatterns for now,
Cheers,
--
Pierre-Yves David
More information about the Mercurial-devel
mailing list