[PATCH] grep: add the option to show full commit hash for every result

[Matt Mackall]

On Thu, 2016-02-04 at 18:04 +0000, Kostia Balytskyi wrote:
> 
> On 2/4/16, 5:54 PM, "Augie Fackler" <raf at durin42.com> wrote:
> 
> > On Thu, Feb 04, 2016 at 07:23:59AM -0800, Kostia Balytskyi wrote:
> > > # HG changeset patch
> > > # User Kostia Balytskyi <ikostia at fb.com>
> > > # Date 1454599288 28800
> > > #      Thu Feb 04 07:21:28 2016 -0800
> > > # Node ID 436dfb325e8ce1b9cdad569a2bbe408a0d33bb5f
> > > # Parent  d73a5ab18015f61ac61e6e77256512fd82b03818
> > > grep: add the option to show full commit hash for every result
> > 
> > I didn't look at the full patch, but did you consider adding full
> > templater support to the output for grep? That would let us avoid
> > having an extra one-off flag.
> 
> I did not think of it, but that is a fix of much greater magnitude anyway.
> My fix is cheap and solves a very concrete problem, so I see the point
> in it.

It is cheap, I will agree.

But I think you have to agree that it's not particularly high-value. And that it
incurs a non-zero cost in code size and ongoing maintenance. And remember, once
we add this flag, we are committing to keeping it in the code FOREVER.

Since we already have a nice framework to add a much more powerful, generic knob
without too much pain, we've lost interest in accruing more low-value knobs like
this.

https://www.mercurial-scm.org/wiki/GenericTemplatingPlan

-- 
Mathematics is the supreme nostalgia of our time.