[PATCH 3 of 3] graphmod: use different styles for different edge types

[Pierre-Yves David]

On 02/19/2016 09:40 PM, Tim Delaney wrote:
> On 20 February 2016 at 06:44, Sean Farley <sean at farley.io
> <mailto:sean at farley.io>> wrote:
>
>
>     Martijn Pieters <mj at zopatista.com <mailto:mj at zopatista.com>> writes:
>
>     > # HG changeset patch
>     > # User Martijn Pieters <mjpieters at fb.com <mailto:mjpieters at fb.com>>
>     > # Date 1455902539 0
>     > #      Fri Feb 19 17:22:19 2016 +0000
>     > # Node ID 1bd1587ea3d6f5a07e0ca6f7498515bc6a96a07a
>     > # Parent  3f78472bf42c4d9a6243e5bd9ee5729a32f4cdff
>     > graphmod: use different styles for different edge types
>     >
>     > Rather than always draw edges as solid lines, use dotted lines for edges that
>     > do not connect to a parent, and dashed lines when connecting to a grandparent
>     > (implying missing nodes in between).
>     >
>     > This is part of the work towards moving smartlog upstream; currently smartlog
>     > injects extra nodes into the graph to indicate grandparent relationships (nodes
>     > elided).
>
>     This took me a little while to review but seems to work for me. I like
>     the direction!
>
>
> I'm not sure about using the fullstop/period - it doesn't look like a
> path to me. I experimented with a few things, and to me using an
> exclamation mark for grandparent and colon for non-parent looks best
> whilst still being visually distinctive.

Don't forget we'll want to display "evolution" (successors/precursors) 
history with another kind of line so we should not burn all our char 
just yet.


As for non-parent, We should probably not pick a different kind of line 
there, but just alter the grapher to not make the line live forever. 
Having lines that goes nowhere "die" as soon as possible would be valuable.

-- 
Pierre-Yves David