[PATCH 3 of 3 V2] pull: deactivate a bookmark not matching with the destination of the update

[Pierre-Yves David]

On 02/27/2016 04:46 PM, FUJIWARA Katsunori wrote:
> At Sat, 27 Feb 2016 14:38:25 +0100,
> Pierre-Yves David wrote:
>>
>> On 02/26/2016 12:25 PM, FUJIWARA Katsunori wrote:
>>> # HG changeset patch
>>> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
>>> # Date 1456485725 -32400
>>> #      Fri Feb 26 20:22:05 2016 +0900
>>> # Node ID 351794f863dbd56fa787714bb1986da2b506ace4
>>> # Parent  8bc889107331ed73969ec1e5364bdd380f736299
>>> pull: deactivate a bookmark not matching with the destination of the update
>>>
>>> Before this patch, "hg pull -u" doesn't deactivate a current active
>>> bookmark, which doesn't match with the explicit destination of the
>>> update, even though bare "hg update" does so.
>>
>> Same as with previous patch:
>>
>> In practice, it looks like your are talking about:
>>
>> 'hg pull -u --rev bmname'
>>
>> am I right? if so, we should probably update the commit message to have
>> the '--rev bmname' bits
>>
>> This seems to also apply to `hg pull -u URL#bmname too.
>
> Yes, this patch focuses on "hg pull -u" with argument below (ANOTHER
> should be different from current active bookmark name):
>
>    - option --rev ANOTHER
>    - option --branch ANOTHER
>    - source URL#ANOTHER
>
>
>> If so, I think the change make sense (probably requires a BC) flagging.
>>
>> If you agree with the aboves, we can probably update the message in flight.
>
> Please do so.

I did just pushed them.


-- 
Pierre-Yves David