[PATCH STABLE] dockerrpm: fix CentOS 5 RPMs (issue4977)

[Anton Shestakov]

05.01.2016, 04:27, "Mathias De Mar" <mathias.demare at gmail.com>:
> # HG changeset patch
> # User Mathias De Maré <mathias.demare at gmail.com>
> # Date 1451938919 -3600
> # Mon Jan 04 21:21:59 2016 +0100
> # Branch stable
> # Node ID 51b021f55c0abba924d3008b8dbabc35116a5a49
> # Parent 7c598947fbbd78b26989326c61345c6e46855bdc
> dockerrpm: fix CentOS 5 RPMs (issue4977)
>
> The older rpmbuild in CentOS 5 fails if some of the output directories
> have not been created yet. This change results in creating those directories.
>
> diff --git a/contrib/dockerrpm b/contrib/dockerrpm
> --- a/contrib/dockerrpm
> +++ b/contrib/dockerrpm
> @@ -15,6 +15,8 @@
>  RPMBUILDDIR=$ROOTDIR/packages/$PLATFORM
>  contrib/buildrpm --rpmbuilddir $RPMBUILDDIR --prepare $*
>
> +mkdir -p $RPMBUILDDIR/{BUILD,SRPMS,RPMS}

I'm not sure if dockerrpm is the best place for this mkdir call. Could we put this into buildrpm? As you can see, dockerrpm calls buildrpm --prepare, which already calls mkdir for SOURCES and SPECS. Also creating BUILD, SRPMS and RPMS there seems logical (and would probably help users running buildrpm on their centos machines).