[PATCH v3] rollback: add a config knob for entirely disabling the command
Sean Farley
sean at farley.io
Wed May 4 21:50:19 UTC 2016
Augie Fackler <raf at durin42.com> writes:
> (+ a couple of people that seem to be reliable UX oracles)
>> On May 4, 2016, at 12:53, Adrian Buehlmann <adrian at cadifra.com> wrote:
>>
>> On 2016-05-04 17:03, Augie Fackler wrote:
>>> # HG changeset patch
>>> # User Augie Fackler <augie at google.com>
>>> # Date 1462307605 14400
>>> # Tue May 03 16:33:25 2016 -0400
>>> # Node ID 689b8a0a3c5e32e8c7b1358b51fd87d69207973c
>>> # Parent 8eba4cdcfd810d80785c94d770a442c5bd1f9d0f
>>> rollback: add a config knob for entirely disabling the command
>>>
>>> This is of pretty high value for organizations that used to use p4 (as
>>> an example), since `p4 rollback` is what we call `hg blackout`.
>
> [snip]
>
>>> + [255]
>>
>> I don't really care that much myself, but why don't you add
>>
>> ui.rollback
>>
>> with a default value of True?
>>
>> Users who want to disable that command could then specify
>>
>> [ui]
>> rollback = false
>>
>> In a future release, the default could be changed to False.
>
> Ooh, nice. That avoids the slightly confusing double-negative as well. If I don't hear any objections in the next couple of hours, I'll roll a v4 with that version of things.
I like this suggestion (double negatives are really confusing to me and
maybe foreign speakers).
More information about the Mercurial-devel
mailing list