Fixing .hg file open ordering

[Durham Goode]

On 11/9/16, 4:51 PM, "Augie Fackler" <raf at durin42.com> wrote:

    On Wed, Nov 02, 2016 at 03:39:50PM -0700, Bryan O'Sullivan wrote:
    > On Wed, Nov 2, 2016 at 3:30 PM, Durham Goode <durham at fb.com> wrote:
    >
    > > Bookmark writes are now within the wlock, and any inmemory read you did
    > > prior to taking the lock will be invalidated (during the next
    > > repo._bookmarks access) and thrown away when you take the lock. So once
    > > you're in the lock you are guaranteed to get the latest version off disk,
    > > and guaranteed that no one else will modify it until you release the lock.
    > >
    >
    > OK, great, that was the step I was missing when reading the code.
    
    Based on my quick scan of this thread, it sounds like you've worked
    out a solution for this?
 
We worked out a solution to Bryan’s main concern, but there hasn’t been any discussion of my main proposal.  Internally we worked around it by forcing bookmarks and the changelog to load in the right order very early during repo setup, but that’s a hack and doesn’t address the greater problem.