[PATCH] color: show mode warning based on ui.formatted

Yuya Nishihara yuya at tcha.org
Fri Nov 11 14:12:32 UTC 2016


On Thu, 10 Nov 2016 20:36:25 -0800, Sean Farley wrote:
> Xidorn Quan <me at upsuper.org> writes:
> > # HG changeset patch
> > # User Xidorn Quan <me at upsuper.org>
> > # Date 1478829965 -39600
> > #      Fri Nov 11 13:06:05 2016 +1100
> > # Node ID 1ffdeb65f19e74ea211af4d9f7c9c4c1dfaa7069
> > # Parent  e1d6aa0e4c3aed73e0dc523b8a8fd5f9fe23510a
> > color: show mode warning based on ui.formatted

LGTM, too. Queued, thanks.

> Today I learned that ui.interactive is only for input and ui.formatted
> is for ouput:
> 
> "This [interactive] function refers to input only; for output, see
> `ui.formatted()'."
> 
> The patch looks good to me (maybe add some explanation to the commit
> message but that shouldn't require a resend).

Copy-edited the commit message to include "ui.interactive is only for input..."



More information about the Mercurial-devel mailing list