[PATCH] dispatch: include resolved command name when logging command

[Augie Fackler]

> On Nov 20, 2016, at 6:08 AM, Yuya Nishihara <yuya at tcha.org> wrote:
> 
> On Wed, 16 Nov 2016 17:48:06 -0500, Augie Fackler wrote:
>>> On Nov 16, 2016, at 17:39, Augie Fackler <raf at durin42.com> wrote:
>>> 
>>> Wait, I missed something semi-obvious: this isn't the full resolved command name, so it's not what I had in mind. I'll send a more complete patch once I get that sorted.
>> 
>> Oh, wait. I misread test output, which is probably a hint that this could use a more formal test somehow. I'm open to suggestions on that front, or if people are comfortable with it I'm also happy to see it land as-is.
> 
> Seems fine to land as-is. Do we need to update the docstring of ui.log(),
> which says "**opts currently has no defined meanings” ?

Oh, good catch. I’ll add that and do a resend.

> 
>>>> On Nov 16, 2016, at 17:36, Augie Fackler <raf at durin42.com> wrote:
>>>> This will be useful for anyone that wants to log the specific command
>>>> that was executed without having to parse the joined command line
>>>> arguments.
> 
> We could extend the event "command" to "command.<cmd>" (and make blackbox
> support prefix match) if the purpose of the cmd argument is filtering.

For my needs, it’s actually so I can log the command the user typed without having to re-do argument parsing on the command line - at work we want to have an idea of how long various commands take, and our infrastructure works best when we’ve got protocol buffers as output, so we’ve got a custom internal blackbox-like extension that does that.

I’ll send a new version on Monday.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20161120/2e1b0310/attachment.asc>