[PATCH 7 of 8 V5] exchange: use `bookmarks` bundle2 part

Pierre-Yves David pierre-yves.david at ens-lyon.org
Thu Oct 6 11:36:26 UTC 2016



On 10/05/2016 11:53 AM, Stanislau Hlebik wrote:
> Hey.
>
> Sorry for late response.
> To run `bookmod.updatefromremote()` from part handler we need to pass url of the remote and explicitly requested bookmarks
> to `bookmarks` part handler. That means that we either need to create bundleoperation() in _pullbundle2() method and
> pass it to processbundle() or pass remoteurl and explicitbookmarks as parameters to processbundle. The former is fine but according to the comment in processbundle() - `this ability will probably go away in the process`, the latter adds parameters that are only related to
> `bookmarks` part.

Creating the bundleoperation beforehand is fine. It is possible to do so 
to handle this kind of case. This kind of data seems to belong to the 
bundleoperation object (as they are part of the unbundle-wide context).

-- 
Pierre-Yves David



More information about the Mercurial-devel mailing list