[PATCH] py3: revset - change iteritems to items

Augie Fackler raf at durin42.com
Sat Oct 8 16:44:28 UTC 2016


On Sat, Oct 08, 2016 at 09:37:09AM -0700, Mateusz Kwapich wrote:
> # HG changeset patch
> # User Mateusz Kwapich <mitrandir at fb.com>
> # Date 1475944606 25200
> #      Sat Oct 08 09:36:46 2016 -0700
> # Node ID 18cee0bbfd402a5005b286b723a6a495bf86a165
> # Parent  02795fabd7daf1b35b4d36de3dbca16e55a63451
> py3: revset - change iteritems to items

After consultation at the py3 table at the sprint, we're discarding
this in favor of a fix to the source importer.

>
> If we'll ever have so many revset predicated so that using "items" is creating
> pref problems we'll have bigger problem than just that.
>
> diff --git a/mercurial/revset.py b/mercurial/revset.py
> --- a/mercurial/revset.py
> +++ b/mercurial/revset.py
> @@ -3835,7 +3835,7 @@ def prettyformatset(revs):
>  def loadpredicate(ui, extname, registrarobj):
>      """Load revset predicates from specified registrarobj
>      """
> -    for name, func in registrarobj._table.iteritems():
> +    for name, func in registrarobj._table.items():
>          symbols[name] = func
>          if func._safe:
>              safesymbols.add(name)
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel



More information about the Mercurial-devel mailing list