[PATCH 3 of 5] py3: slots should be unicode strings (pywatchman)

[Mateusz Kwapich]

Oh – I see, in that case please disregard all pywatchman related patches in this series.

On 10/9/16, 4:00 PM, "Pulkit Goyal" <7895pulkit at gmail.com> wrote:

    Thanks for all the patches related to Python 3.
    I think we should better don't touch pywatchman because they have
    already worked on it and will be sending a pull request to Mercurial
    soon. https://github.com/facebook/watchman/pull/247
    
    
    On Sun, Oct 9, 2016 at 3:55 PM, Mateusz Kwapich <mitrandir at fb.com> wrote:
    > # HG changeset patch
    > # User Mateusz Kwapich <mitrandir at fb.com>
    > # Date 1476021239 25200
    > #      Sun Oct 09 06:53:59 2016 -0700
    > # Node ID dd705da68bdc7e52ca7a06e92e0fb6e74af6647b
    > # Parent  9be0fc83663857b8843a781b6418a42fa0b15c65
    > py3: slots should be unicode strings (pywatchman)
    >
    > like in mercurial/util.py:566
    >
    > diff --git a/hgext/fsmonitor/pywatchman/pybser.py b/hgext/fsmonitor/pywatchman/pybser.py
    > --- a/hgext/fsmonitor/pywatchman/pybser.py
    > +++ b/hgext/fsmonitor/pywatchman/pybser.py
    > @@ -236,7 +236,7 @@ def _bunser_array(buf, pos, mutable=True
    >  # It provides by getattr accessors and getitem for both index
    >  # and name.
    >  class _BunserDict(object):
    > -    __slots__ = ('_keys', '_values')
    > +    __slots__ = (u'_keys', u'_values')
    >
    >      def __init__(self, keys, values):
    >          self._keys = keys
    > _______________________________________________
    > Mercurial-devel mailing list
    > Mercurial-devel at mercurial-scm.org
    > https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_mailman_listinfo_mercurial-2Ddevel&d=DQIBaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=dK7q_6fOymlfdGMBe3wUaA&m=1-XbIaJuAl-e6Lg1NICyls-c0U1uZDjaHV-HNV_HJW0&s=p-jtl_eqLk_TQGwHoWjMXSYpJpG_Ujwis11ipVmwVuw&e=