[PATCH 11 of 11] upgrade: drop the prefix to the '_finishdatamigration' function
Ryan McElroy
rm at fb.com
Mon Apr 10 19:35:59 UTC 2017
On 4/10/17 5:49 PM, Pierre-Yves David wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> # Date 1491840382 -7200
> # Mon Apr 10 18:06:22 2017 +0200
> # Node ID 9edd96848f91a5dfe6e713846b968483a8a28618
> # Parent ac8de371f662e5647d68cd67b721d6a0c37f1340
> # EXP-Topic upgraderepo
> upgrade: drop the prefix to the '_finishdatamigration' function
This series looks good to me; it's a straightforward code cleanup with
some nice wins in function name size.
Marked as pre-reviewed on patchwork.
>
> Now that we are in the 'upgrade' module we can simplify the name.
>
> diff --git a/mercurial/upgrade.py b/mercurial/upgrade.py
> --- a/mercurial/upgrade.py
> +++ b/mercurial/upgrade.py
> @@ -487,7 +487,7 @@ def _filterstorefile(srcrepo, dstrepo, r
>
> return True
>
> -def _upgradefinishdatamigration(ui, srcrepo, dstrepo, requirements):
> +def _finishdatamigration(ui, srcrepo, dstrepo, requirements):
> """Hook point for extensions to perform additional actions during upgrade.
>
> This function is called after revlogs and store files have been copied but
> @@ -534,7 +534,7 @@ def _upgraderepo(ui, srcrepo, dstrepo, r
> dst = dstrepo.store.vfs.join(p)
> util.copyfile(src, dst, copystat=True)
>
> - _upgradefinishdatamigration(ui, srcrepo, dstrepo, requirements)
> + _finishdatamigration(ui, srcrepo, dstrepo, requirements)
>
> ui.write(_('data fully migrated to temporary repository\n'))
>
>
More information about the Mercurial-devel
mailing list