[PATCH 1 of 2 STABLE] diffhelpers: add canstripcr=True to fix_newline

Yuya Nishihara yuya at tcha.org
Wed Apr 26 11:39:30 UTC 2017


On Tue, 25 Apr 2017 15:29:25 -0700, Jun Wu wrote:
> Excerpts from Augie Fackler's message of 2017-04-25 18:20:06 -0400:
> > Valid point. For now, let's preserve that invariant - Jun, can you make
> > sure v2 has a graceful degradation path if it gets an old .so?
> 
> My understanding is while reasonable, we try to maintain compatibility in
> both directions. i.e. it's a best-effort.
> 
> For this particular fix, If we enforce that rule, it means we have to use a
> new method name, and copy paste hundreds of lines, *and* have dead code in
> the repo.

We only need to copy pure.fix_newline(). It wouldn't hurt switching to pure
fix_newline() because the function is quite simple.

> I don't think that's a good thing. So I'm not going to do that.
> But maybe other people have different opinions, or a smarter way to fix this
> without copy-paste.

I have a patch set to get rid of the whole mess of pure/c-ext import hacks.
Hopefully the copy-paste will die in 4.3.



More information about the Mercurial-devel mailing list