D244: obsolete: rename _addprecursors into _addpredecessors
lothiraldan (Boris Feld)
phabricator at mercurial-scm.org
Mon Aug 7 10:08:55 UTC 2017
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Use util.nouideprecwarn because _addpredecessors doesn't have easy access to
an ui object.
The renaming is done according to
https://www.mercurial-scm.org/wiki/CEDVocabulary.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D244
AFFECTED FILES
mercurial/obsolete.py
CHANGE DETAILS
diff --git a/mercurial/obsolete.py b/mercurial/obsolete.py
--- a/mercurial/obsolete.py
+++ b/mercurial/obsolete.py
@@ -470,11 +470,18 @@
for mark in markers:
successors.setdefault(mark[0], set()).add(mark)
+def _addprecursors(*args, **kwargs):
+ msg = ("'obsolete._addprecursors' is deprecated, "
+ "use 'obsolete._addpredecessors'")
+ util.nouideprecwarn(msg, '4.4')
+
+ return _addpredecessors(*args, **kwargs)
+
@util.nogc
-def _addprecursors(precursors, markers):
+def _addpredecessors(predecessors, markers):
for mark in markers:
for suc in mark[1]:
- precursors.setdefault(suc, set()).add(mark)
+ predecessors.setdefault(suc, set()).add(mark)
@util.nogc
def _addchildren(children, markers):
@@ -660,9 +667,9 @@
@propertycache
def precursors(self):
- precursors = {}
- _addprecursors(precursors, self._all)
- return precursors
+ predecessors = {}
+ _addpredecessors(predecessors, self._all)
+ return predecessors
@propertycache
def children(self):
@@ -680,7 +687,7 @@
if self._cached('successors'):
_addsuccessors(self.successors, markers)
if self._cached('precursors'):
- _addprecursors(self.precursors, markers)
+ _addpredecessors(self.precursors, markers)
if self._cached('children'):
_addchildren(self.children, markers)
_checkinvalidmarkers(markers)
To: lothiraldan, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list