D447: templatekw: choose {latesttag} by len(changes), not date (issue5659)
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Sat Aug 19 16:29:41 UTC 2017
martinvonz added inline comments.
INLINE COMMENTS
> yuja wrote in templatekw.py:222
> > I'm not changing latesttagdistance (AFAIK), only the definition of latesttag.
>
> Try `ptags = reversed(...)` and run tests. The largest `pdist` should be selected
> so that `latesttagdistance` returns the longest path.
>> I'm not changing latesttagdistance (AFAIK), only the definition of latesttag.
>
> Try ptags = reversed(...) and run tests. The largest pdist should be selected
> so that latesttagdistance returns the longest path.
Ah, right, when the tag is in the common ancestor, we should choose the longest branch. Good catch. See how you like this change.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D447
To: martinvonz, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list