D477: revlog: add option to mmap revlog index
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Fri Aug 25 02:18:34 UTC 2017
indygreg added inline comments.
INLINE COMMENTS
> mbthomas wrote in test-revlog-mmapindex.t:12-13
> For (1) There's no `ui` object available in the `revlog.revlog` constructor. Is there a way to get one?
> For (2), the rest of the test suite will be loading the revlog without mmap, so I didn't think it necessary to test it again here.
I'd do it with inline Python. Something like:
>>> from mercurial import hg, ui as uimod
>>> myui = uimod.ui.load()
>>> repo = hg.repository(myui, path='.')
>>>
>>> 1. Test repo.changelog here.
Also, excessive `hg` commands makes tests slow. Unfortunately, doing this in Python is probably a bit of work :/
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D477
To: mbthomas, #fbhgext, indygreg, #hg-reviewers, durin42
Cc: quark, durin42, simonfar, mercurial-devel
More information about the Mercurial-devel
mailing list