D1617: rebase: extract _assignworkingcopy

krbullock (Kevin Bullock) phabricator at mercurial-scm.org
Sat Dec 9 04:42:36 UTC 2017


krbullock added inline comments.

INLINE COMMENTS

> rebase.py:393
> +    def _performrebase(self, tr):
> +        self._assignworkingcopy()
> +        repo, ui = self.repo, self.ui

Rather than having this method spookily set self.wctx, why not make `_assignworkingcopy` _return_ the wctx (and rename it accordingly)?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1617

To: phillco, #hg-reviewers, dlax
Cc: krbullock, mercurial-devel


More information about the Mercurial-devel mailing list