D1753: streamclone: preserve remote phases (issue5648)

[yuja (Yuya Nishihara)]

yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> streamclone.py:191
> +        # to draft. Then we apply the remote phases data.
> +        if remotephases:
> +            roots = [ctx.node() for ctx in repo.set('roots(all())')]

Shouldn't we test `remotephases.get('publishing', False)` for
mixed-phase + publishing server?

> streamclone.py:200
> +            publicheads, draftroots = phases.analyzeremotephases(
> +                repo, repo.heads(), {hex(n): phases.draft for n in roots})
> +

It seems odd that `remotephases` data aren't used at all, but
I'm not sure.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1753

To: indygreg, #hg-reviewers, yuja
Cc: yuja, mercurial-devel