[PATCH 1 of 8 simple] color: spread '_effect' values for readability

[Martin von Zweigbergk]

On Feb 16, 2017 01:06, "Pierre-Yves David" <pierre-yves.david at ens-lyon.org>
wrote:



On 02/15/2017 09:49 PM, Martin von Zweigbergk wrote:

> On Wed, Feb 15, 2017 at 3:06 AM, Pierre-Yves David
> <pierre-yves.david at ens-lyon.org> wrote:
>
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
>> # Date 1479491019 -3600
>> #      Fri Nov 18 18:43:39 2016 +0100
>> # Node ID 42d4b49b39d6879065209ea3ca71f1e3fa88fcbc
>> # Parent  354020079723e02ad6db68f58ef26eb7ebd005a8
>> # EXP-Topic color
>> color: spread '_effect' values for readability
>>
>> We move to our "usual" one value per line style.
>>
>
> Nit: the even more usual style (by a factor 2-2.5, it seems) is to put
> the values on separate lines from the curly braces. But I won't let
> that stop the patch, of course.
>

Just ot be sure, You mean:


_effects = {
    'none': 0,
    black': 30,
}

Right?


Exactly. With the closing brace like that too (but a few were different).
That's also my preferred form, which is probably why I even noticed.

That seemed to be more common if I was grepping right. But your form was
used consistently (?) in color.py, so that was probably the right choice in
this case anyway.




-- 
Pierre-Yves David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170216/898f92b5/attachment-0002.html>