[PATCH 2 of 2] summary: don't indicate a clean wdir() with deleted files (issue5549)

[Yuya Nishihara]

On Mon, 03 Jul 2017 22:30:34 -0400, Matt Harbison wrote:
> I'm fine with making the presence of '+' in `hg identify` output be the  
> way to tell dirty or not, as long as '!' in a subrepo triggers a '+' on  
> the top level repo.

Agreed. sub.dirty() would need "missing" flag as ctx.dirty() has.

> (Though it seems like there could be an explicit line  
> and text in `hg summary` too.)

Perhaps.

>  Maybe to alleviate the confusion, change  
> 'clean' here to 'uncommittable'?  Or 'nothing', to be less scary?  (Though  
> at that point we've broken anything parsing it, so IDK if slightly  
> changing the meaning matters too much.)

Not sure if 'uncommittable' is the right word, which sounds like committing
is proactively disabled. 'nothing' is slightly obscure, but seems better than
'uncommittable'.

> I also think that the --check flag needs to be fixed up too.

--check for deleted files in subrepos? Perhaps.