[PATCH 3 of 6 V2] rebase: use scmutil.cleanupnodes (issue5606) (BC)
Jun Wu
quark at fb.com
Sat Jul 8 06:04:35 UTC 2017
Excerpts from Martin von Zweigbergk's message of 2017-07-07 22:59:55 -0700:
> I just checked that the obsmarkers are produced in deterministic order
> (independent of dict iteration order). However, bookmarks get moved in
> dict iteration order. Maybe we should make sure that's also
> deterministic? Can probably move the sorting you do for obsmarkers a
> bit earlier and reuse that sorted list of tuples.
Good point. I guess it is not causing problems since no test tests the
"moving bookmarks" debug message. But "debugobsolete" does rely on marker
orders. Maybe we need to make the debug message exposed somewhere and fix
the sorting.
More information about the Mercurial-devel
mailing list