Experimenting with Phabricator for reviews

[Sean Farley]

Phillip Cohen <phillip at phillip.io> writes:

>> Also: Jun has suggested to me that we should avoid using "Accept
>> Commit", because that should be a state applied only when a commit is
>> queued to `hg-committed` (either by the reviewer or by a future bot).
>> Once the commit goes to `hg` it should be automatically closed (this
>> should happen today out of the box).
>>
>> Those two things make sense to me, but it's the first I've heard of
>> it, and wanted to make sure there was consensus.
>
> Although, hm, I find this rather annoying because I have to check
> whether a review is a core review or an fb-hgext review before I know
> if I can use the Accept functionality. :/

Historically, this is done via different mailing lists: hgsubversion,
hg-git, etc. are all separate lists. I would think fb-hgext and whatnot
could be separate lists, too, no?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170712/6fc81fe3/attachment.asc>