D114: run-tests: pass color option via options object, not global var

[martinvonz (Martin von Zweigbergk)]

martinvonz updated this revision to Diff 252.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D114?vs=225&id=252

REVISION DETAIL
  https://phab.mercurial-scm.org/D114

AFFECTED FILES
  tests/run-tests.py

CHANGE DETAILS

diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -1564,16 +1564,14 @@
         self.successes = []
         self.faildata = {}
 
-        global with_color
         if not self.stream.isatty(): # check if the terminal is capable
-            with_color = False
-
-        if options.color != 'auto':
-            if options.color == 'never':
-                with_color = False
-            else: # 'always', for testing purposes
-                if pygmentspresent:
-                    with_color = True
+            options.color = False
+        elif options.color == 'auto':
+            options.color = with_color
+        elif options.color == 'never':
+            options.color = False
+        else: # 'always', for testing purposes
+            options.color = pygmentspresent
 
     def addFailure(self, test, reason):
         self.failures.append((test, reason))
@@ -1652,7 +1650,7 @@
                 else:
                     self.stream.write('\n')
                     for line in lines:
-                        if with_color and pygmentspresent:
+                        if self._options.color and pygmentspresent:
                             line = pygments.highlight(
                                     line,
                                     lexers.DiffLexer(),



EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: martinvonz, #hg-reviewers
Cc: mercurial-devel