D153: test-dirstate-race: replace BROKEN line with explanation of changed output

sid0 (Siddharth Agarwal) phabricator at mercurial-scm.org
Thu Jul 20 16:04:38 UTC 2017


sid0 added inline comments.

INLINE COMMENTS

> martinvonz wrote in test-dirstate-race.t:223-231
> Oh, the "hg status" is just to cause it to write the dirstate? Would "hg debugrebuilddirstate" work? That doesn't produce any output and it's clearer that that will result in the dirstate getting written ("hg status" doesn't always write it, as I'm sure you know). If that would work, we can delete the whole comment, I think.

I'm afraid not -- debugrebuilddirstate will try to acquire the wlock, which is already held by the rebase.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D153

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: sid0, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list