D171: phabricator: include the suggested arc config in the repo
simpkins (Adam Simpkins)
phabricator at mercurial-scm.org
Tue Jul 25 01:42:45 UTC 2017
simpkins accepted this revision.
simpkins added a comment.
This looks good to me too.
Personally I would vote for setting `history.immutable` to `false` too. This mostly affects the behavior of the `arc diff` and `arc amend` commands. This probably won't matter at all for people that submit diffs using the `phabsend` extension instead of `arc diff`.
When set to false, `arc diff` will rewrite your local commit message to include the differential revision ID when submitting a diff. `arc amend` will update your commit message to add a `Reviewed By` line once your diff has been accepted.
Personally I find it useful to have this information in my local commit messages. (The `phabdiff` and `phabstatus` extensions in the rFBHGEXT repository can also report some useful information if they find this field present in your commit message.)
The only downside of leaving `history.immutable` as `true` is that you don't get this information in your commit message when running `arc diff` / `arc amend`; it shouldn't impact any other behavior.
One arguable downside of setting `history.immutable` to `false` is that your local commit IDs do change after running `arc diff` or `arc amend` if it needed to update your commit message.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D171
To: alex_gaynor, durin42, #hg-reviewers, simpkins
Cc: simpkins, quark, durham, mercurial-devel
More information about the Mercurial-devel
mailing list