[PATCH 10 of 11] log: add obsfate by default in changeset printer

[Boris Feld]

On Tue, 2017-10-10 at 03:00 +0530, Pulkit Goyal wrote:
> On Tue, Oct 10, 2017 at 12:10 AM, Boris Feld <boris.feld at octobus.net>
> wrote:
> > # HG changeset patch
> > # User Boris Feld <boris.feld at octobus.net>
> > # Date 1507209918 -7200
> > #      Thu Oct 05 15:25:18 2017 +0200
> > # Node ID 1943f74e8e4cb6bd1d44910898fffcaec7a56ca1
> > # Parent  14824410b05da8d360ddd65c1f8727cc3bafb111
> > # EXP-Topic obsfatekeyword
> > # Available At https://bitbucket.org/octobus/mercurial-devel/
> > #              hg pull https://bitbucket.org/octobus/mercurial-deve
> > l/ -r 1943f74e8e4c
> > log: add obsfate by default in changeset printer
> > 
> > Having an obsfate by default in log will be useful for users to
> > understand why
> > they have obsolete and unstable changesets. Obsfate will only be
> > shown for
> > obsolete changesets, which only happens if people opt-in to
> > experimental feature.
> > 
> > But when obsolete changeset are visible, it is very useful to
> > understand where
> > they are. Having it in log could be sufficient for most people, so
> > they don't
> > have to learn a new command (like obslog which is itself useful in
> > case of
> > divergences).
> > 
> > For example, when pulling and working directory parent become
> > obsolete:
> > 
> >   $ hg pull
> >   ...
> >   working directory parent is obsolete! (f936c1697205)
> 
> I think you should mention that this message comes from evolve.

Ha yes, I thought it was coming from core.

> 
> > 
> > Obsfate would comes handy:
> > 
> >   $ hg log -G
> >   o  changeset:   2:6f91013c5136
> >   |  tag:         tip
> >   |  parent:      0:4ef7b558f3ec
> >   |  user:        Boris Feld <boris.feld at octobus.net>
> >   |  date:        Mon Oct 09 16:00:27 2017 +0200
> >   |  summary:     A
> >   |
> >   | @  changeset:   1:f936c1697205
> >   |/   user:        Boris Feld <boris.feld at octobus.net>
> >   |    date:        Mon Oct 09 16:00:27 2017 +0200
> >   |    obsolete:    reworded as 6f91013c5136
> 
>           ^^^^^^---> obsolete or obsfate?
> 
> Can you change the above example as it shows a section named obsolete
> and your patch says add obsfate. I realized after checking that above
> obsolete thing is output from 'evolve extension'.

Yes, I got confused by almost the same output format. Will update and
send a V2.

> 
> >   |    summary:     -A
> > 
> > And once we update, obsfate is not shown anymore:
> 
> I don't understand what you wanted to convey here. The obsfate is not
> shown because the hidden changeset is not shown. I think I can still
> see the obsfate of that changeset by `hg log --hidden`.


I wanted to show that in most cases, having obsfate in default
changeset printer would not add extra information because it's not
everyday that you should see an obsolete changeset in your log without
using --hidden.