D1074: branch: add a --rev flag to change branch name of given revisions

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Tue Oct 17 13:26:50 UTC 2017


pulkit added inline comments.

INLINE COMMENTS

> ryanmce wrote in cmdutil.py:791-792
> Seems like we need a refactor? (out of scope for this change though)

Yeah, I will be happy to do that in next cycle. Can you suggest a name for file in which we can split cmdutil.py.

> ryanmce wrote in test-branch-change.t:304-305
> Hm, I think I'd prefer this to be an error about public changesets rather than a no-op with a 0 return value. Trying to modify the branch of public changesets -- even if the change is a no-op, still seems like an error to me. Thoughts?

Oh, no. They are not public changesets. The test for public changeset is just above it. I will plug the phase info in the glog output in next version.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1074

To: pulkit, #hg-reviewers, dlax, ryanmce
Cc: ryanmce, dlax, mercurial-devel


More information about the Mercurial-devel mailing list