[PATCH] phases: bring phase index information back into the hook data

[Kevin Bullock]

> On Oct 19, 2017, at 05:10, Boris Feld <boris.feld at octobus.net> wrote:
> 
> # HG changeset patch
> # User Boris Feld <boris.feld at octobus.net>
> # Date 1508406933 -7200
> #      Thu Oct 19 11:55:33 2017 +0200
> # Node ID 667730ee4a87977f86b22cf0d66f959990753fdb
> # Parent  315e04247750ad4983d648d3ba002eb328624b70
> # EXP-Topic fix-phase-hooks
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 667730ee4a87
> phases: bring phase index information back into the hook data
> 
> The phase information are included in the hook argument as "$HG_PHASEIDX" and
> "$HG_OLDPHASEIDX". The name format matches the one used by the phase related
> templates ('{phase}' and '{phaseidx}').
> 
> The phase index was available in the pushkey hooks. And having the numeric
> value makes it simpler to compares the value. So we bring the information back
> for the new phase related hooks.

After some offline discussion I'm going to table this. I'm skeptical that the phase indexes are getting much use in real pushkey hooks, and I and other reviewers have expressed a desire to keep these integers from leaking out any further. I'm surprised there's even a template keyword for them, but given that, migrated phase hooks can get the integers that way if they really must.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock