D515: phabricator: standardize colors

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Fri Sep 1 13:03:28 UTC 2017


yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> phabricator.py:443
> +        drevdesc = ui.label('D%s' % newrevid, 'phabricator.drev')
> +        actiondesc = ui.label(_(action), 'phabricator.action.%s' % action)
> +        nodedesc = ui.label(bytes(ctx), 'phabricator.node')

You'll need a mapping from action to _('...'). gettext isn't smart
to capture all possible `action` values.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D515

To: quark, #hg-reviewers, indygreg, yuja
Cc: yuja, indygreg, mercurial-devel


More information about the Mercurial-devel mailing list