[PATCH v2] command options: abort on unicode defaults

[Christophe de Vienne]

Le 01/09/2017 à 09:31, Christophe de Vienne a écrit :
> 
> 
> Le 31/08/2017 à 23:50, Jun Wu a écrit :
>> Excerpts from Christophe de Vienne's message of 2017-08-31 23:26:58 +0200:
[...]
>>>
>>> diff -r b2eb0aa445cb -r 5bbb2d585a96 mercurial/dispatch.py
>>> --- a/mercurial/dispatch.py    Tue Aug 22 21:21:43 2017 -0400
>>> +++ b/mercurial/dispatch.py    Tue Aug 29 18:24:51 2017 +0200
>>> @@ -557,7 +557,15 @@
>>>          if defaults:
>>>              args = pycompat.maplist(
>>>                  util.expandpath, pycompat.shlexsplit(defaults)) + args
>>> -        c = list(entry[1])
>>
>> Changing here means it only works for global opts. Is that intentional?
> 
> no, and I realize I changed the line (I removed the list()), which I did
> not intended.
> 
> That said, I am not sure what you mean by "it only works for global
> opts". What are global opts?

Re-reading the source, it seems to be the other way around: the global
opts are not checked, only the ones of the command.


-- 
Christophe de Vienne