D529: uncommit: move fb-extension to core which uncommits a changeset

[quark (Jun Wu)]

quark requested changes to this revision.
quark added a comment.
This revision now requires changes to proceed.


  Please address other reviewers' comments.

INLINE COMMENTS

> uncommit.py:12
> +
> +"""uncommit some or all of a local changeset
> +

I'd add "(EXPERIMENTAL)". The command does not write `unamend_source` so it's in theory problematic with the current obsstore design.

> yuja wrote in uncommit.py:176
> Can't we use scmutil.cleanupnodes()?

Yep. That will also make `_updatebookmarks` unnecessary.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D529

To: pulkit, #hg-reviewers, quark
Cc: quark, martinvonz, yuja, mercurial-devel