D696: registrar: add a enum 'cmdtype' for the type of the command
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Fri Sep 15 13:40:46 UTC 2017
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
To make it less controversial, I would move these constants to registrar.command
class and rename them to lowercaseconstants. The registrar provides semi-public
API, which should be consistently named.
I think this should be folded to the other registrar patch, and sent with the patches
which actually change the behavior depending on the cmdtype value. So marked as
change requested.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D696
To: pulkit, #hg-reviewers, durham, yuja
Cc: yuja, durham, indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list