D730: revlog: add revmap back to revlog.addgroup
durham (Durham Goode)
phabricator at mercurial-scm.org
Wed Sep 20 16:43:43 UTC 2017
durham marked an inline comment as done.
durham added a comment.
I've updated the message and attached 3 more commits to the stack that update debugbundle, bundlerepo, and the deltachunk fix you suggested.
INLINE COMMENTS
> martinvonz wrote in changegroup.py:191-192
> I'll repeat my comment from https://phab.mercurial-scm.org/D688: This now seems unnecessary since the first thing you do is to convert it back into a very similar tuple. Do you think the is still useful? Maybe use a named tuple if we want the names? Either way, that's not for this patch, of course.
I've added a diff to the end of the stack to change it to a tuple. No need for names I think, since the return value is only consumed internal to the class.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D730
To: durham, indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list