D748: cleanupnodes: separate out bookmark destination calculation from actual update

[martinvonz (Martin von Zweigbergk)]

martinvonz marked an inline comment as done.
martinvonz added a comment.


  In https://phab.mercurial-scm.org/D748#12944, @quark wrote:
  
  > I noticed the change from `repo` to `unfi`. That actually looks better. Since we are not querying "descendants", it won't cause correctness issues.
  
  
  Yes, that was necessary because oldnode could be obsolete and that was previously protected by "if not oldbmarks", which I didn't think would belong in the new loop.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D748

To: martinvonz, #hg-reviewers, quark
Cc: quark, mercurial-devel