D3000: addremove: remove opts from scmutil.addremove

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sun Apr 1 01:57:17 UTC 2018


yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  Sorry, I didn't notice that the opts dict carries extra options other
  than subrepos, dry_run, and similarity. Because of that, my idea of
  dropping `opts` turns out to be worse than the current state.
  
  Maybe we can get rid of `dry_run` and `similarity` instead, but we'll
  have to be careful since the default `similarity` value varies on command.

INLINE COMMENTS

> commands.py:252
> +    subrepos, after = opts.get('subrepos'), opts.get('after')
> +    large, lfsize = opts.get('large'), opts.get('lfsize')
>      try:

Oops, largefiles options in core.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3000

To: khanchi97, #hg-reviewers, yuja
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list