D2873: remotenames: add functionality to override -B flag of push
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Wed Apr 11 20:55:14 UTC 2018
indygreg added a comment.
In https://phab.mercurial-scm.org/D2873#52025, @smf wrote:
> In https://phab.mercurial-scm.org/D2873#52021, @indygreg wrote:
>
> > Looks good!
>
>
> I'm very heavily against this direction. Changing the behavior of push (even in this extension) is something I've always considered outside the scope of remotenames. Having another extension that changes push behavior (e.g. bookmark-push) is where I think this should go so that remotenames is just that: keeping track of remote names.
I think there's room for this feature to live outside of remotenames. But currently I think it is the best place for it, since remotenames is the closest thing we have to... tracking remote names. We can always alias the old config option in the future if we move this functionality elsewhere.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2873
To: pulkit, #hg-reviewers, indygreg
Cc: smf, indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list