D3427: hgweb: reuse body file object when hgwebdir calls hgweb (issue5851)

[mharbison72 (Matt Harbison)]

mharbison72 added a comment.


  > A test demonstrating hg clone and hg push via hgwebdir has been
  >  added. Without this patch, the test hangs when doing hg clone.
  >  Surprisingly, this must mean that we have effectively no test coverage
  >  of the wire protocol when run via hgwebdir.
  
  I thought that hgwebdir testing is pretty light too, but there should be at least some additional coverage with subrepos.  But maybe something is subtly different.  For example, there's not an obvious difference between this new clone test, and this existing one:
  
  https://www.mercurial-scm.org/repo/hg/file/8c8b6d13949a/tests/test-subrepo-recursion.t#l266
  
  While there's no prefix on this clone, there is on in its subrepo.

INLINE COMMENTS

> test-push-http.t:399
> +  > [extensions]
> +  > showstack = $TESTDIR/../contrib/showstack.py
> +  > EOF

This needs to be excluded on Windows.  Maybe I should just trap the error that gets raised, so that this loads but does nothing?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3427

To: indygreg, #hg-reviewers
Cc: mharbison72, mercurial-devel